Ximon Eighteen
509e2f2fc4
Use actual disk files instead of creating input files on the fly, as this makes it easier to run commands on the same data outside the test and simplifies the test fn definition.
2024-12-11 10:35:09 +01:00
Ximon Eighteen
0ca4502a5c
Use a dedicated flag also available to dnst to select output of YYYYMMDDHHmmSS RRSIG timestamps.
2024-12-11 10:33:11 +01:00
Ximon Eighteen
b724fd7467
Use error context to indicate which path could not be loaded.
2024-12-11 10:32:05 +01:00
Ximon Eighteen
e1eef5c5c7
Add a placeholder for a test of the RFC 5155 NSEC3 zone signing example.
2024-12-10 16:44:12 +01:00
Ximon Eighteen
42abba1b3b
Added a test showing that the RFC 1035 appendix A zone signing example works, with the exception of newly found issue https://github.com/NLnetLabs/domain/issues/468 .
2024-12-10 16:42:28 +01:00
Ximon Eighteen
db477c7e51
Move test helper functions to the end.
2024-12-10 14:37:06 +01:00
Ximon Eighteen
211a182a1c
Add placeholder tests for known issues.
2024-12-10 14:26:04 +01:00
Ximon Eighteen
06af01c466
Print ";\n" lines in -b mode only after each "family". ( fixes #44 )
2024-12-10 13:56:36 +01:00
Ximon Eighteen
fa8b7ec637
Clippy.
2024-12-10 12:55:48 +01:00
Ximon Eighteen
ac39540caa
When invoked as LDNS write RRSIG timestamps in RFC 4034 3.2 YYYYMMDDHHmmSS format instead of seconds since the epoch format.
2024-12-10 12:52:32 +01:00
Ximon Eighteen
320ec01c17
Cargo fmt.
2024-12-09 16:29:06 +01:00
Ximon Eighteen
5c9e65f110
Bump domain to latest.
2024-12-09 16:28:37 +01:00
Ximon Eighteen
4c69c3a31b
Bump domain to latest and fix tests to match new tabbed LDNS compatible zonefile format.
2024-12-09 16:22:46 +01:00
Ximon Eighteen
57aeaa5aa8
FIX: Don't output SOA RRSIG twice when not using -b.
2024-12-09 12:43:58 +01:00
Ximon Eighteen
8331b5cc4b
Bump domain to latest.
2024-12-09 12:28:06 +01:00
Jannik Peters
1c647c8345
Check signing mode for when using ZONEMD
2024-12-09 12:22:33 +01:00
Ximon Eighteen
ba0d67afcb
Re-order dev dependencies alphabetically and use the pretty_assertions crate to get more readable assert_eq() diff output.
2024-12-09 11:55:04 +01:00
Ximon Eighteen
6498e30f1d
Document differences in output ordering compared to the original LDNS.
2024-12-09 11:52:02 +01:00
Ximon Eighteen
ee3b37ecb6
Document the difference in RRSIG timestamp output format.
2024-12-09 11:49:32 +01:00
Ximon Eighteen
ee5e86a45d
Strip ZONEMD RRs on load so that signing without ZONEMD doesn't leave an incorrect ZONEMD RR in the output.
2024-12-09 10:30:11 +01:00
Ximon Eighteen and GitHub
43c6f7caee
Remove temporary local diagnostics.
2024-12-08 00:48:41 +01:00
Ximon Eighteen
bdb4f6e766
Ignore NSEC3PARAM RRs on loading the zone as a new one should be generated, otherwise a duplicate RR error can occur.
...
Note an incompatiblity with RFC 5155 advice on transitioning a zone from NSEC3 to NSEC.
2024-12-08 00:38:51 +01:00
Ximon Eighteen
f56eb7b472
Rename and fix the signing key fallback usage strategy.
2024-12-08 00:34:05 +01:00
Ximon Eighteen
b52846f64a
Update to match changes in SigningKeyUsageStrategy in latest domain.
2024-12-06 13:05:11 +01:00
Ximon Eighteen
bf46691474
Output the test line that failed, not a line in a helper fn.
2024-12-05 15:03:40 +01:00
Ximon Eighteen
02276ea255
Fix nsec3 tests to match updated default iteration count.
2024-12-05 13:59:51 +01:00
Ximon Eighteen
7a361ca4ca
FIX: Don't print RRSIGs twice.
2024-12-05 13:58:31 +01:00
Ximon Eighteen
3f655654a1
Update to latest domain to use new tabbed zonefile formatting to match LDNS.
2024-12-05 13:28:09 +01:00
Ximon Eighteen
e403d24bee
Use updated strategy fn naming.
2024-12-05 13:00:02 +01:00
Ximon Eighteen
d355527834
Fix behaviour with only KSKs to match LDNS: treat them as ZSKs. Add a test to verify it against actual LDNS behaviour.
2024-12-05 12:38:09 +01:00
Ximon Eighteen
f90c096b91
Cargo fmt.
2024-12-05 11:31:16 +01:00
Ximon Eighteen
5fbfd6183c
Fix broken nsec3-hash integration test, and update ldns=nsec3-hash to also use 0 iterations by default (which makes it now inconsistent with main so this may be revisited later).
2024-12-05 11:28:50 +01:00
Ximon Eighteen
16a9f5aa98
Output the test line that failed, not a line in a helper fn.
2024-12-05 11:27:58 +01:00
Ximon Eighteen
121505f7d3
Clippy.
2024-12-05 11:08:30 +01:00
Ximon Eighteen
e2810b218d
Add an integration test based on an existing LDNS test.
2024-12-05 10:59:56 +01:00
Ximon Eighteen
09e0732065
FIX: Incorrect error message from test ldns binary if the given command lacks the ldns- prefix.
2024-12-05 10:57:17 +01:00
Ximon Eighteen
f81d10447d
- FIX: Default LDNS KSK selection strategy is NOT to honour the key purpose but instead to fallback to using ZSKs as KSKs if there are no KSKs.
...
- FIX: Don't output ENT comments if `-b` is not in use.
- ENH: Only order RRSIGs after covered RRSETs if `-b` is in use.
- ENH: In DNST mode, don't output any RR comments unless `-b` is in use, unlike LDNS which still outputs DNSKEY key tag comments when `-b` is not in use.
2024-12-05 10:56:50 +01:00
Ximon Eighteen
f041882c65
Minor man page tweak.
2024-12-05 09:39:45 +01:00
Ximon Eighteen
1db62afc16
Make it clear that in the LDNS emulation case the stripping of NSEC(3) and RRSIG RRs is a deviation from the original ldns-signzone behaviour.
2024-12-05 09:39:06 +01:00
Ximon Eighteen
c76928709a
Update man pages to match NSEC(3) and RRSIG stripping behaviour.
2024-12-05 09:31:42 +01:00
Ximon Eighteen
f0d77d653a
Strip NSEC(3) and RRSIG RRs from the loaded zone so that we always only sign an unsigned zone, as it's unclear what the actual / intended original ldns-signzone behaviour when processing an already signed zone is supposed to be.
2024-12-05 09:30:04 +01:00
Ximon Eighteen
c5450e228f
Update the ldns-signzone manual page to more closely reflect the implemented behaviour.
2024-12-05 09:17:46 +01:00
Jannik Peters
76e255a20c
Simplify line filter functions
2024-12-04 13:25:33 +01:00
Jannik Peters
5a57b66723
Fix extra newline in line filter
2024-12-04 12:37:41 +01:00
Ximon Eighteen
ff32c80c53
Remove commented line.
2024-12-03 23:55:00 +01:00
Ximon Eighteen
924f32a497
Remove wrongly committed files.
2024-12-03 23:53:57 +01:00
Ximon Eighteen
5c97fc4e5b
Revert tabbed output changes in preparation to use the PR #446 approach instead.
2024-12-03 23:49:02 +01:00
Ximon Eighteen
2c1dfeb523
Merge branch 'main' into add-ldns-like-sign-zone-support
2024-12-03 23:47:39 +01:00
Ximon Eighteen
4ed6478798
Clippy.
2024-12-03 23:19:19 +01:00
Ximon Eighteen
489d762444
- Upgrade to latest domain changes.
...
- Add support for `-A`.
- Add support for `-U`.
- Fix failure to print additional RRSIGs when signing with more than one key.
2024-12-03 21:25:52 +01:00