WEBDIENSTE/YellowLabTools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Handle the case when the CSS parsing fails

Browse Source
This commit is contained in:
Gaël Métais
2014-09-25 18:15:37 +02:00
parent dd9e41252c
commit 312e33d15d
2 changed files with 32 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/node_views/results.html
+22
View File
@@ -289,6 +289,17 @@
<div class="notation">CSS complexity</div>
<div class="criteria">
<div class="table">
<div ng-if="cssParsingError">
<div class="label">CSS syntax error</div>
<div class="result"></div>
<div class="info">
<div class="icon-question" ng-click="cssRulesTooltip = true"></div>
<modal-dialog show="cssRulesTooltip" dialog-title="Parsing error while analyzing CSS">
<p>You cannot let this kind of problem on your website!</p>
<p>Use a <a href="http://jigsaw.w3.org/css-validator" target="_blank">CSS validator</a> to find where the syntax error is.</p>
</modal-dialog>
</div>
</div>
<div ng-if="phantomasResults.metrics.cssRules">
<div class="label">Rules count</div>
<div class="result">{{phantomasResults.metrics.cssRules}}</div>
@@ -322,6 +333,17 @@
<div class="notation">Bad CSS</div>
<div class="criteria">
<div class="table">
<div ng-if="cssParsingError">
<div class="label">CSS syntax error</div>
<div class="result"></div>
<div class="info">
<div class="icon-question" ng-click="cssRulesTooltip = true"></div>
<modal-dialog show="cssRulesTooltip" dialog-title="Parsing error while analyzing CSS">
<p>You cannot let this kind of problem on your website!</p>
<p>Use a <a href="http://jigsaw.w3.org/css-validator" target="_blank">CSS validator</a> to find where the syntax error is.</p>
</modal-dialog>
</div>
</div>
<div ng-if="phantomasResults.metrics.cssDuplicatedSelectors">
<div class="label">Duplicated selectors</div>
<div class="result">
app/public/scripts/resultsCtrl.js
+10 -2
View File
@@ -70,6 +70,10 @@ app.controller('ResultsCtrl', function ($scope) {
});
}
// Check if the CSS was correctly parsed
$scope.cssParsingError = (!$scope.phantomasResults.metrics.cssRules && $scope.phantomasResults.metrics.cssCount > 0);
// Grab the notes
$scope.notations = {
domComplexity: getDomComplexityScore(),
domManipulations: getDomManipulationsScore(),
@@ -300,7 +304,9 @@ app.controller('ResultsCtrl', function ($scope) {
}
function getCSSComplexityScore() {
if (!$scope.phantomasResults.metrics.cssRules) {
if ($scope.cssParsingError) {
return 'F';
} else if (!$scope.phantomasResults.metrics.cssRules) {
return 'NA';
}
@@ -326,7 +332,9 @@ app.controller('ResultsCtrl', function ($scope) {
}
function getBadCssScore() {
if (!$scope.phantomasResults.metrics.cssRules) {
if ($scope.cssParsingError) {
return 'F';
} else if (!$scope.phantomasResults.metrics.cssRules) {
return 'NA';
}