Handle the case when the CSS parsing fails

2014-09-25 18:15:37 +02:00
parent dd9e41252c
commit 312e33d15d
2 changed files with 32 additions and 2 deletions
@@ -70,6 +70,10 @@ app.controller('ResultsCtrl', function ($scope) {
            });
        }

+        // Check if the CSS was correctly parsed
+        $scope.cssParsingError = (!$scope.phantomasResults.metrics.cssRules && $scope.phantomasResults.metrics.cssCount > 0);
+
+        // Grab the notes
        $scope.notations = {
            domComplexity: getDomComplexityScore(),
            domManipulations: getDomManipulationsScore(),
@@ -300,7 +304,9 @@ app.controller('ResultsCtrl', function ($scope) {
    }

    function getCSSComplexityScore() {
-        if (!$scope.phantomasResults.metrics.cssRules) {
+        if ($scope.cssParsingError) {
+            return 'F';
+        } else if (!$scope.phantomasResults.metrics.cssRules) {
            return 'NA';
        }

@@ -326,7 +332,9 @@ app.controller('ResultsCtrl', function ($scope) {
    }

    function getBadCssScore() {
-        if (!$scope.phantomasResults.metrics.cssRules) {
+        if ($scope.cssParsingError) {
+            return 'F';
+        } else if (!$scope.phantomasResults.metrics.cssRules) {
            return 'NA';
        }