WEBDIENSTE/YellowLabTools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Warning more visible if bind on multiple elements

Browse Source
This commit is contained in:
Gaël Métais
2014-11-03 11:32:47 +01:00
parent a2217a9178
commit 5e6a7fc6b6
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/node_views/results.html
+9 -4
View File
@@ -766,9 +766,12 @@
</div>
<div class="details">
<div class="icon-question"
ng-click="onNodeDetailsClick(node)"
ng-if="node.data.type != 'jQuery loaded'
<div ng-class="{
'icon-question': !(node.data.type == 'jQuery - bind' && node.data.callDetails.context.length > 5),
'icon-warning': node.data.type == 'jQuery - bind' && node.data.callDetails.context.length > 5
}"
ng-click="onNodeDetailsClick(node)"
ng-if="node.data.type != 'jQuery loaded'
&& node.data.type != 'jQuery version change'
&& node.data.type != 'domInteractive'
&& node.data.type != 'domContentLoaded'
@@ -789,7 +792,9 @@
<div ng-if="node.data.callDetails.context.length > 1">
<h4>Called on {{node.data.callDetails.context.length}} jQuery elements</h4>
<p class="advice" ng-if="node.data.callDetails.context.length > 5">The .bind() method attaches the event listener to each jQuery element one by one. Using the .on() method is preferred if available (from v1.7).</p>
<p class="advice" ng-if="node.data.type == 'jQuery - bind' && node.data.callDetails.context.length > 5">
The .bind() method attaches the event listener to each jQuery element one by one. Using the .on() method is preferable if available (from v1.7).
</p>
<p ng-if="node.data.callDetails.context.firstElementPath"><b>First one is:</b> {{node.data.callDetails.context.firstElementPath}}</p>
</div>