WEBDIENSTE/YellowLabTools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

New notations on Summary : jQuery version and Events bound

Browse Source
This commit is contained in:
Gaël Métais
2014-09-03 16:19:32 +02:00
parent 87ecb47d3d
commit 61f97f4856
2 changed files with 55 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/node_views/results.html
+9 -1
View File
@@ -45,13 +45,21 @@
<div ng-class="notations.domManipulations">{{notations.domManipulations}}</div>
<div>DOM read and write Requests</div>
</div>
<div>
<div ng-class="notations.eventsBound">{{notations.eventsBound}}</div>
<div>Events bound</div>
</div>
<div>
<div ng-class="notations.duplicatedDomQueries">{{notations.duplicatedDomQueries}}</div>
<div>Duplicated DOM queries</div>
</div>
<div>
<div ng-class="notations.badPractices">{{notations.badPractices}}</div>
<div>Javascript bad practices</div>
<div>Evil Javascript</div>
</div>
<div>
<div ng-class="notations.jQueryLoading">{{notations.jQueryLoading}}</div>
<div>jQuery version</div>
</div>
</div>
app/public/scripts/resultsCtrl.js
+46 -1
View File
@@ -67,7 +67,9 @@ app.controller('ResultsCtrl', function ($scope) {
domComplexity: 'A',
domManipulations: 'A',
duplicatedDomQueries: 'A',
badPractices: 'A'
eventsBound: 'A',
badPractices: 'A',
jQueryLoading: 'A'
};
var domComplexityScore = $scope.phantomasResults.metrics.DOMelementsCount
@@ -108,6 +110,23 @@ app.controller('ResultsCtrl', function ($scope) {
$scope.notations.domManipulations = 'F';
}
var eventsBoundScore = $scope.phantomasResults.metrics.eventsBound;
if (eventsBoundScore > 50) {
$scope.notations.eventsBound = 'B';
}
if (eventsBoundScore > 100) {
$scope.notations.eventsBound = 'C';
}
if (eventsBoundScore > 200) {
$scope.notations.eventsBound = 'D';
}
if (eventsBoundScore > 500) {
$scope.notations.eventsBound = 'E';
}
if (eventsBoundScore > 1000) {
$scope.notations.eventsBound = 'F';
}
var duplicatedDomQueries = $scope.duplicatedQueriesCountAll;
if (duplicatedDomQueries > 20) {
$scope.notations.duplicatedDomQueries = 'B';
@@ -144,6 +163,32 @@ app.controller('ResultsCtrl', function ($scope) {
if (badPracticesScore > 40) {
$scope.notations.badPractices = 'F';
}
$scope.notations.jQueryLoading = 'NA';
if ($scope.phantomasResults.metrics.jQueryDifferentVersions > 1) {
$scope.notations.jQueryLoading = 'F';
} else if ($scope.phantomasResults.metrics.jQueryVersion) {
if ($scope.phantomasResults.metrics.jQueryVersion.indexOf('1.10.') === 0
|| $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.11.') === 0
|| $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.12.') === 0
|| $scope.phantomasResults.metrics.jQueryVersion.indexOf('2.0.') === 0
|| $scope.phantomasResults.metrics.jQueryVersion.indexOf('2.1.') === 0
|| $scope.phantomasResults.metrics.jQueryVersion.indexOf('2.2.') === 0) {
$scope.notations.jQueryLoading = 'A';
} else if ($scope.phantomasResults.metrics.jQueryVersion.indexOf('1.8.') === 0
|| $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.9.') === 0) {
$scope.notations.jQueryLoading = 'B';
} else if ($scope.phantomasResults.metrics.jQueryVersion.indexOf('1.6.') === 0
|| $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.7.') === 0) {
$scope.notations.jQueryLoading = 'C';
} else if ($scope.phantomasResults.metrics.jQueryVersion.indexOf('1.4.') === 0
|| $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.5.') === 0) {
$scope.notations.jQueryLoading = 'D';
} else if ($scope.phantomasResults.metrics.jQueryVersion.indexOf('1.2.') === 0
|| $scope.phantomasResults.metrics.jQueryVersion.indexOf('1.3.') === 0) {
$scope.notations.jQueryLoading = 'E';
}
}
}
function initExecutionView() {