WEBDIENSTE/YellowLabTools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add cssRedundantChildNodesSelectors rule

Browse Source
This commit is contained in:
Gaël Métais
2014-11-12 11:23:47 +01:00
parent ace02138ff
commit 6bb2be532a
2 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/node_views/results.html
+14
View File
@@ -504,6 +504,20 @@
</modal-dialog>
</div>
</div>
<div ng-if="phantomasResults.metrics.cssRedundantChildNodesSelectors">
<div class="label">Redundant tags selectors</div>
<div class="result">
{{phantomasResults.metrics.cssRedundantChildNodesSelectors}}
<show-offenders modal-title="Redundant tags selectors" metric-name="cssRedundantChildNodesSelectors" phantomas-results="phantomasResults"></show-offenders>
</div>
<div class="info">
<div class="icon-question" ng-click="cssRedundantChildNodesSelectorsTooltip = true"></div>
<modal-dialog show="cssRedundantChildNodesSelectorsTooltip" dialog-title="Useless redundant selectors">
<p>Some tags included inside other tags are obvious. For example, when "ul li" is specified in a rule, "ul" can be removed because the "li" element is <b>always</b> inside a "ul". Same thing for "tr td", "select option", ...</p>
<p>Lowering compexity in CSS selectors can make the page load a little faster.</p>
</modal-dialog>
</div>
</div>
</div>
</div>
</div>
app/public/scripts/resultsCtrl.js
+5 -4
View File
@@ -263,7 +263,7 @@ app.controller('ResultsCtrl', function ($scope) {
var note = 'A';
var score = $scope.phantomasResults.metrics.cssRules +
$scope.phantomasResults.metrics.cssComplexSelectors * 5 +
$scope.phantomasResults.metrics.cssComplexSelectorsByAttribute * 15;
$scope.phantomasResults.metrics.cssComplexSelectorsByAttribute * 10;
if (score > 500) {
note = 'B';
}
@@ -298,12 +298,13 @@ app.controller('ResultsCtrl', function ($scope) {
$scope.phantomasResults.metrics.cssOldIEFixes * 10 +
$scope.phantomasResults.metrics.cssOldPropertyPrefixes +
$scope.phantomasResults.metrics.cssUniversalSelectors * 5 +
$scope.phantomasResults.metrics.cssRedundantBodySelectors +
($scope.phantomasResults.metrics.cssImports || 0) * 50;
$scope.phantomasResults.metrics.cssRedundantBodySelectors * 0.5 +
$scope.phantomasResults.metrics.cssRedundantChildNodesSelectors * 0.5 +
$scope.phantomasResults.metrics.cssImports * 50;
if (score > 50) {
note = 'B';
}
if (score > 10) {
if (score > 100) {
note = 'C';
}
if (score > 200) {