WEBDIENSTE/YellowLabTools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

#2 Better CSS parsing error message

Browse Source
This commit is contained in:
Gaël Métais
2014-11-20 11:10:10 +01:00
parent fe37d4e91c
commit a1278fad49
2 changed files with 42 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/node_views/results.html
+28 -14
View File
@@ -277,6 +277,34 @@
</div>
</div>
</div>
<div ng-if="phantomasResults.metrics.cssParsingErrors">
<div class="F">F</div>
<div class="notation">CSS errors</div>
<div class="criteria">
<div class="table">
<div class="warning">
<div class="label">CSS files with syntax errors</div>
<div class="result">
{{phantomasResults.metrics.cssParsingErrors}}
<show-offenders modal-title="CSS syntax errors" metric-name="cssParsingErrors" phantomas-results="phantomasResults"></show-offenders>
</div>
<div class="info">
<div class="icon-question" ng-click="cssRulesTooltip = true"></div>
<modal-dialog show="cssRulesTooltip" dialog-title="Parsing error while analyzing CSS">
<p>Yellow Lab Tools failed to parse a CSS file. I doubt the problem comes from the css parser.</p>
<p>
Check directly on <b>W3C CSS Validator</b>:
<ul>
<li ng-repeat="stylesheet in cssW3cDirectUrls">
<a href="{{stylesheet.w3c}}" target="_blank">{{stylesheet.url}}</a>
</li>
</ul>
</modal-dialog>
</div>
</div>
</div>
</div>
</div>
<div>
<div ng-class="notations.cssComplexity">{{notations.cssComplexity}}</div>
<div class="notation">CSS complexity</div>
@@ -339,20 +367,6 @@
<div class="notation">Bad CSS</div>
<div class="criteria">
<div class="table">
<div ng-if="phantomasResults.metrics.cssParsingErrors" class="warning">
<div class="label">CSS syntax error</div>
<div class="result">
{{phantomasResults.metrics.cssParsingErrors}}
<show-offenders modal-title="CSS syntax errors" metric-name="cssParsingErrors" phantomas-results="phantomasResults"></show-offenders>
</div>
<div class="info">
<div class="icon-question" ng-click="cssRulesTooltip = true"></div>
<modal-dialog show="cssRulesTooltip" dialog-title="Parsing error while analyzing CSS">
<p>Yellow Lab Tools failed to parse a CSS file. I doubt the problem comes from the css parser.</p>
<p>Maybe a <a href="http://jigsaw.w3.org/css-validator" target="_blank">CSS validator</a> can help you.</p>
</modal-dialog>
</div>
</div>
<div ng-if="phantomasResults.metrics.cssImports" class="warning">
<div class="label">Uses of @import</div>
<div class="result">
app/public/scripts/resultsCtrl.js
+14 -3
View File
@@ -64,6 +64,19 @@ app.controller('ResultsCtrl', function ($scope) {
}
});
// If there are some CSS parsing errors, prepare the W3C CSS Validator direct URLs
if ($scope.phantomasResults.offenders.cssParsingErrors) {
$scope.cssW3cDirectUrls = [];
$scope.phantomasResults.offenders.cssParsingErrors.forEach(function(errorString, index) {
var stylesheet = errorString.split(' ')[0];
var w3cUrl = 'http://jigsaw.w3.org/css-validator/validator?profile=css3&usermedium=all&warning=no&vextwarning=true&lang=en&uri=' + encodeURIComponent(stylesheet);
$scope.cssW3cDirectUrls.push({
url: stylesheet,
w3c: w3cUrl
});
});
}
// Grab the notes
$scope.notations = {
domComplexity: getDomComplexityScore(),
@@ -283,9 +296,7 @@ app.controller('ResultsCtrl', function ($scope) {
}
function getBadCssScore() {
if ($scope.phantomasResults.metrics.cssParsingErrors) {
return 'F';
} else if (!$scope.phantomasResults.metrics.cssRules) {
if (!$scope.phantomasResults.metrics.cssRules) {
return 'NA';
}