WEBDIENSTE/YellowLabTools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Warn when a jQuery function is called on an empty object

Browse Source
This commit is contained in:
Gaël Métais
2014-11-03 16:45:10 +01:00
parent 3ae318c9bc
commit c3b4b30603
1 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/node_views/results.html
+19 -4
View File
@@ -726,6 +726,10 @@
The table below shows the interactions between Javascript and the DOM. It is usefull to understand what's going on when the page loads.
</p>
<div class="filters">
<div>
<input type="checkbox" ng-model="warningsFilterOn" />
Show warnings only
</div>
<div>
<input type="checkbox" ng-model="textFilterOn" />
Filter by
@@ -743,13 +747,19 @@
<div>Timestamp</div>
</div>
<div ng-repeat="node in javascript.children"
ng-if="!textFilterOn
ng-if="(!warningsFilterOn
|| (node.data.type == 'jQuery - bind' && node.data.callDetails.context.length > 5)
|| node.data.resultsNumber === 0
|| node.data.callDetails.context.length === 0
|| node.data.type == 'error'
|| node.data.type == 'jQuery version change')
&& (!textFilterOn
|| !textFilter.length
|| node.data.type.indexOf(textFilter) >= 0
|| node.data.callDetails.arguments[0].indexOf(textFilter) >= 0
|| node.data.callDetails.arguments[1].indexOf(textFilter) >= 0
|| node.data.callDetails.arguments[2].indexOf(textFilter) >= 0
|| node.data.callDetails.arguments[3].indexOf(textFilter) >= 0"
|| node.data.callDetails.arguments[3].indexOf(textFilter) >= 0)"
ng-class="{
showingDetails: node.data.showDetails,
jsError: node.data.type == 'error' || node.data.type == 'jQuery version change',
@@ -767,8 +777,8 @@
<div class="details">
<div ng-class="{
'icon-question': !(node.data.type == 'jQuery - bind' && node.data.callDetails.context.length > 5) && node.data.resultsNumber !== 0,
'icon-warning': node.data.type == 'jQuery - bind' && node.data.callDetails.context.length > 5 || node.data.resultsNumber === 0
'icon-question': !(node.data.type == 'jQuery - bind' && node.data.callDetails.context.length > 5) && node.data.resultsNumber !== 0 && node.data.callDetails.context.length !== 0,
'icon-warning': node.data.type == 'jQuery - bind' && node.data.callDetails.context.length > 5 || node.data.resultsNumber === 0 || node.data.callDetails.context.length === 0
}"
ng-click="onNodeDetailsClick(node)"
ng-if="node.data.type != 'jQuery loaded'
@@ -785,6 +795,11 @@
<div>{{node.data.callDetails.context.domElement}}</div>
</div>
<div ng-if="node.data.callDetails.context.length === 0">
<h4>Called on 0 jQuery element</h4>
<p class="advice">Useless function call, as the jQuery object is empty.</p>
</div>
<div ng-if="node.data.callDetails.context.length == 1 && node.data.callDetails.context.firstElementPath">
<h4>Called on 1 jQuery element</h4>
<div>{{node.data.callDetails.context.firstElementPath}}</div>