Dashboard users can now edit their name and email language

This commit is contained in:
Karl Ludwig Weise
2026-07-28 20:33:48 +02:00
parent 67ccfd8bff
commit 9a6a960e4f
12 changed files with 427 additions and 6 deletions
+10 -2
View File
@@ -131,7 +131,7 @@
"logout": {
"title": "Abmelden",
"success": {
"title": "Du wurdest abgemeldet.",
"title": "Bis bald",
"description": "Du wurdest abgemeldet."
},
"error": {
@@ -757,7 +757,15 @@
"general": {
"navItem": "Einstellungen",
"title": "Kontoeinstellungen",
"description": "Ändere Deinen Namen oder die Sprache für E-Mails."
"description": "Ändere Deinen Namen oder die Sprache für E-Mails.",
"language": {
"title": "E-Mail Sprache",
"placeholder": "Wähle eine Sprache",
"hint": "OpenReception sendet E-Mails in dieser Sprache an Dich"
},
"action": "Änderungen speichern",
"success": "Konto-Einstellungen gespeichert",
"error": "Konto-Einstellungen konnten nicht gespeichert werden"
},
"change-email": {
"navItem": "E-Mail Adresse",
+11 -3
View File
@@ -139,8 +139,8 @@
"logout": {
"title": "Logout",
"success": {
"title": "You are logged out.",
"description": "You are logged-out."
"title": "Have a good day",
"description": "You are now logged out."
},
"error": {
"title": "Logout failed",
@@ -765,7 +765,15 @@
"general": {
"navItem": "Settings",
"title": "Account Settings",
"description": "Change your name and e-mail language."
"description": "Change your name and e-mail language.",
"language": {
"title": "E-Mail Language",
"placeholder": "Select a language",
"hint": "OpenReception will send e-mails in this language to you"
},
"action": "Save changes",
"success": "Account Settings saved",
"error": "Account Settings could not be saved"
},
"change-email": {
"navItem": "E-Mail Address",
+2
View File
@@ -1,4 +1,5 @@
import { browser } from "$app/environment";
import type { SupportedLocale } from "$lib/const/locales";
import type { UserRole } from "$lib/server/auth/authorization-service";
import { writable } from "svelte/store";
@@ -17,6 +18,7 @@ export interface AuthState {
email: string;
name: string;
role: UserRole;
language: SupportedLocale;
// The currently selected tenant
tenantId?: string | null;
};
@@ -7,6 +7,7 @@ import {
import type { TTenant } from "$lib/types/tenant";
import type { LayoutServerLoad } from "./$types";
import logger from "$lib/logger";
import type { SupportedLocale } from "$lib/const/locales";
const log = logger.setContext("/dashboard/+layout.server.ts");
@@ -25,6 +26,7 @@ export const load: LayoutServerLoad = async (event) => {
name: event.locals.user.name,
email: event.locals.user.email,
role: event.locals.user.role,
language: event.locals.user.language as SupportedLocale,
tenantId: event.locals.user.tenantId,
};
auth.setUser(user);
@@ -0,0 +1,102 @@
<script lang="ts">
import { m } from "$i18n/messages.js";
import * as Form from "$lib/components/ui/form";
import { Input } from "$lib/components/ui/input";
import * as Select from "$lib/components/ui/select";
import { supportedLocales, translatedLocales } from "$lib/const/locales";
import { auth } from "$lib/stores/auth";
import { untrack } from "svelte";
import { toast } from "svelte-sonner";
import { superForm } from "sveltekit-superforms";
import { zod4Client as zodClient } from "sveltekit-superforms/adapters";
import { formSchema } from ".";
let account = $derived($auth.user);
const form = superForm(
{
name: untrack(() => account?.name || ""),
language: untrack(() => account?.language) as string,
},
{
dataType: "json",
validators: zodClient(formSchema),
onResult: async (event) => {
if (event.result.type === "success") {
if (account) {
auth.setUser({
...account,
name: event.result.data?.form.data.name,
language: event.result.data?.form.data.language,
});
}
toast.success(m["account.general.success"]());
} else if (event.result.type === "failure") {
toast.error(m["account.general.error"]());
}
isSubmitting = false;
},
onSubmit: () => (isSubmitting = true),
},
);
$effect(() => {
// Fixes hard reload of page resulting in empty form
if (!$formData.name && account?.name) {
$formData.name = account.name;
$formData.language = account.language;
}
});
let isSubmitting = $state(false);
const { form: formData, enhance } = form;
</script>
{#if account}
<Form.Root {enhance} action="?/edit">
<Form.Field {form} name="name">
<Form.Control>
{#snippet children({ props })}
<Form.Label>{m["form.name"]()}</Form.Label>
<Input {...props} bind:value={$formData.name} type="name" />
{/snippet}
</Form.Control>
<Form.FieldErrors />
</Form.Field>
<Form.Field {form} name="language">
<Form.Control>
{#snippet children({ props })}
<Form.Label>{m["account.general.language.title"]()}</Form.Label>
<Select.Root
type="single"
bind:value={$formData.language}
name={props.name}
onValueChange={(v) => ($formData.language = v)}
>
<Select.Trigger {...props} class="w-full">
{$formData.language
? translatedLocales[$formData.language as keyof typeof translatedLocales]
: m["account.general.language.placeholder"]()}
</Select.Trigger>
<Select.Content>
{#each supportedLocales as locale (locale)}
<Select.Item value={locale}>
{translatedLocales[locale as keyof typeof translatedLocales]}
</Select.Item>
{/each}
</Select.Content>
</Select.Root>
<Form.Description>
{m["account.general.language.hint"]()}
</Form.Description>
{/snippet}
</Form.Control>
<Form.FieldErrors />
</Form.Field>
<div class="mt-6 flex flex-col gap-4">
<Form.Button size="lg" type="submit" isLoading={isSubmitting} disabled={isSubmitting}>
{m["account.general.action"]()}
</Form.Button>
</div>
</Form.Root>
{/if}
@@ -0,0 +1,5 @@
import AccountSettingsForm from "./account-settings-form.svelte";
export { AccountSettingsForm };
export { formSchema } from "./schema";
export type { FormSchema } from "./schema";
@@ -0,0 +1,9 @@
import { m } from "$i18n/messages";
import { z } from "zod";
export const formSchema = z.object({
name: z.string().min(2, m["form.errors.name"]()).max(50, m["form.errors.name"]()),
language: z.string().default("en"),
});
export type FormSchema = typeof formSchema;
@@ -0,0 +1,49 @@
import logger from "$lib/logger";
import { fail, type Actions } from "@sveltejs/kit";
import { superValidate } from "sveltekit-superforms";
import { zod4 as zod } from "sveltekit-superforms/adapters";
import { formSchema as editFormSchema } from "./(components)/account-settings-form";
const log = logger.setContext(import.meta.filename);
export const actions: Actions = {
edit: async (event) => {
const form = await superValidate(event, zod(editFormSchema));
if (!form.valid) {
log.error("Edit account settings form is not valid", { errors: form.errors });
return fail(400, {
form: { ...form, data: { ...form.data } },
error: "Form is not valid",
});
}
const resp = await event.fetch(`/api/me`, {
method: "PUT",
headers: {
"Content-Type": "application/json",
},
credentials: "same-origin",
body: JSON.stringify({
name: form.data.name,
language: form.data.language,
}),
});
if (resp.status < 400) {
return { form };
} else {
let error = "Unknown error";
try {
const body = await resp.json();
error = body.error;
} catch (e) {
log.error("Failed to parse edit account settings error response", { error: e });
}
return fail(resp.status, {
form: { ...form, data: { ...form.data } },
error,
});
}
},
};
@@ -4,6 +4,7 @@
import { SidebarLayout } from "$lib/components/layouts/sidebar-layout";
import { Headline } from "$lib/components/ui/typography";
import { ROUTES } from "$lib/const/routes";
import { AccountSettingsForm } from "./(components)/account-settings-form";
</script>
<SidebarLayout
@@ -20,5 +21,6 @@
>
<MaxPageWidth maxWidth="md" class="flex flex-col gap-6">
<Headline level="h1" style="h3">{m["account.general.title"]()}</Headline>
<AccountSettingsForm />
</MaxPageWidth>
</SidebarLayout>
+3 -1
View File
@@ -26,8 +26,9 @@ registerOpenAPIRoute("/auth/session", "GET", {
name: { type: "string", description: "User name" },
role: { type: "string", enum: ["GLOBAL_ADMIN", "TENANT_ADMIN", "STAFF"] },
tenantId: { type: "string", description: "Tenant ID (if applicable)" },
language: { type: "string", description: "Language for E-Mails" },
},
required: ["id", "email", "name", "role"],
required: ["id", "email", "name", "role", "language"],
},
expiresAt: {
type: "string",
@@ -83,6 +84,7 @@ export const GET: RequestHandler = async ({ locals }) => {
name: locals.user.name,
role: locals.user.role,
tenantId: locals.user.tenantId,
language: locals.user.language,
},
expiresAt: new Date(locals.user.session.exp ?? 0).toISOString(),
});
+137
View File
@@ -0,0 +1,137 @@
/**
* API Route: Dashboard User manages their own account
*/
import { logger } from "$lib/logger";
import { registerOpenAPIRoute } from "$lib/server/openapi";
import { UserService } from "$lib/server/services/user-service";
import {
AuthenticationError,
BackendError,
InternalError,
logError,
ValidationError,
} from "$lib/server/utils/errors";
import type { RequestHandler } from "@sveltejs/kit";
import { json } from "@sveltejs/kit";
import { z } from "zod";
const requestSchema = z.object({
name: z.string().min(2).max(50).optional(),
language: z.enum(["de", "en"]).optional(),
});
// Register OpenAPI documentation for DELETE
registerOpenAPIRoute("/me", "PUT", {
summary: "Update current account",
description: "Allows a staff member to update their current account settings.",
tags: ["Staff", "Account"],
requestBody: {
description: "Account data",
content: {
"application/json": {
schema: {
type: "object",
properties: {
name: {
type: "string",
description: "Name of the staff member",
},
language: {
type: "string",
description: "ISO 639-1 Code",
},
},
},
},
},
},
responses: {
"200": {
description: "Account settings changed",
content: {
"application/json": {
schema: {
type: "object",
properties: {
name: {
type: "string",
example: "John Doe",
},
language: {
type: "string",
example: "en",
},
},
},
},
},
},
"400": {
description: "Invalid request",
content: {
"application/json": {
schema: { $ref: "#/components/schemas/Error" },
},
},
},
"401": {
description: "Unauthorized",
content: {
"application/json": {
schema: { $ref: "#/components/schemas/Error" },
},
},
},
"500": {
description: "Internal server error",
content: {
"application/json": {
schema: { $ref: "#/components/schemas/Error" },
},
},
},
},
});
export const PUT: RequestHandler = async ({ request, locals }) => {
const log = logger.setContext("API.Me");
try {
if (!locals.user) {
throw new AuthenticationError("Unauthorized");
}
const body = await request.json();
const updateData = requestSchema.parse(body);
log.debug("Staff member updating their account", {
userId: locals.user.id,
updateData,
});
// Delete appointment with authentication verification
const user = await UserService.updateUser(locals.user.id, updateData);
log.debug("User updated", {
userId: locals.user.id,
});
return json({
name: user.name,
language: user.language,
});
} catch (error) {
logError(log)("Error updating user", error);
if (error instanceof BackendError) {
return error.toJson();
}
if (error instanceof z.ZodError) {
return new ValidationError("Invalid request data").toJson();
}
return new InternalError().toJson();
}
};
+95
View File
@@ -0,0 +1,95 @@
/* eslint-disable @typescript-eslint/no-explicit-any */
import { describe, it, expect, vi, beforeEach } from "vitest";
import type { RequestEvent } from "@sveltejs/kit";
vi.mock("$lib/server/services/user-service", () => ({
UserService: {
updateUser: vi.fn(),
},
}));
vi.mock("$lib/server/openapi", () => ({
registerOpenAPIRoute: vi.fn(),
}));
vi.mock("$lib/logger", () => ({
logger: {
setContext: vi.fn(() => ({
debug: vi.fn(),
error: vi.fn(),
})),
},
}));
import { PUT } from "./+server";
import { UserService } from "$lib/server/services/user-service";
const mockUser = {
id: "user-123",
name: "Old Name",
language: "en",
};
const createRequestEvent = (body: any, user = mockUser): RequestEvent =>
({
request: {
json: () => Promise.resolve(body),
} as any,
locals: {
user,
},
}) as RequestEvent;
describe("/api/me", () => {
beforeEach(() => {
vi.clearAllMocks();
});
it("updates the authenticated user's account and returns the new values", async () => {
const updatedUser = { ...mockUser, name: "New Name", language: "de" };
vi.mocked(UserService.updateUser).mockResolvedValue(updatedUser as any);
const event = createRequestEvent({ name: "New Name", language: "de" });
const response = await PUT(event);
const body = await response.json();
expect(response.status).toBe(200);
expect(body).toEqual({ name: "New Name", language: "de" });
expect(UserService.updateUser).toHaveBeenCalledWith(mockUser.id, {
name: "New Name",
language: "de",
});
});
it("returns 401 when the request is unauthenticated", async () => {
const event = createRequestEvent({ name: "New Name" }, null as any);
const response = await PUT(event);
const body = await response.json();
expect(response.status).toBe(401);
expect(body.error).toBe("Unauthorized");
expect(UserService.updateUser).not.toHaveBeenCalled();
});
it("returns 422 when the request body is invalid", async () => {
const event = createRequestEvent({ name: "X", language: "fr" });
const response = await PUT(event);
const body = await response.json();
expect(response.status).toBe(422);
expect(body.error).toBe("Invalid request data");
expect(UserService.updateUser).not.toHaveBeenCalled();
});
it("returns 500 when an unexpected error is thrown by the update service", async () => {
vi.mocked(UserService.updateUser).mockRejectedValue(new Error("database outage"));
const event = createRequestEvent({ name: "New Name" });
const response = await PUT(event);
const body = await response.json();
expect(response.status).toBe(500);
expect(body.error).toBe("Internal server error");
});
});