mirror of
https://github.com/hcengineering/huly-selfhost.git
synced 2026-09-28 12:35:05 +02:00
fix(helm): pass GitHub App env vars to front for OAuth and installation flows (#286)
The front service needs two additional env vars when GitHub integration is enabled: - GITHUB_CLIENTID: used to build the OAuth authorize URL. Without it, the redirect has client_id= (empty) and GitHub returns 404. - GITHUB_APP: the app slug, used to build the installation URL. Without it, the URL becomes /apps//installations/new which returns 404. Also adds githubIntegration.appSlug to values.yaml for the app slug. Signed-off-by: Don Kendall <kendall@donkendall.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.6
parent
8fb76e2a22
commit
2a43013d88
@@ -47,6 +47,9 @@ spec:
|
||||
{{- include "huly.envConfig" (dict "name" "LOVE_ENDPOINT" "key" "LOVE_ENDPOINT" "root" .) | nindent 12 }}
|
||||
{{- if .Values.githubIntegration.enabled }}
|
||||
{{- include "huly.envConfig" (dict "name" "GITHUB_URL" "key" "GITHUB_URL" "root" .) | nindent 12 }}
|
||||
{{- include "huly.envSecret" (dict "name" "GITHUB_CLIENTID" "key" "GITHUB_APP_CLIENT_ID" "root" .) | nindent 12 }}
|
||||
- name: GITHUB_APP
|
||||
value: {{ .Values.githubIntegration.appSlug | quote }}
|
||||
{{- end }}
|
||||
{{- if .Values.aibot.enabled }}
|
||||
{{- include "huly.envConfig" (dict "name" "AI_URL" "key" "AI_URL" "root" .) | nindent 12 }}
|
||||
|
||||
@@ -236,6 +236,8 @@ githubIntegration:
|
||||
replicas: 1
|
||||
# Bot name shown on GitHub (must match the GitHub App's slug + [bot])
|
||||
botName: ""
|
||||
# GitHub App slug (from the app URL: github.com/apps/<slug>)
|
||||
appSlug: ""
|
||||
# GitHub App credentials (stored in the shared secret)
|
||||
appId: ""
|
||||
clientId: ""
|
||||
|
||||
Reference in New Issue
Block a user