mirror of
https://github.com/suitenumerique/docs.git
synced 2026-09-06 09:47:52 +02:00
🐛(backend) strip whitespace from media URLs in CORS proxy
When exporting a document to PDF, having whitespace before or after
the media URL causes the image to not be downloaded via the CORS proxy,
resulting in missing images in the exported PDF.
Signed-off-by: Mohamed El Amine BOUKERFA <boukerfa.ma@gmail.com>
This commit is contained in:
@@ -2268,7 +2268,7 @@ class DocumentViewSet(
|
||||
GET /api/v1.0/documents/<resource_id>/cors-proxy
|
||||
Act like a proxy to fetch external resources and bypass CORS restrictions.
|
||||
"""
|
||||
url = request.query_params.get("url")
|
||||
url = request.query_params.get("url", "").strip()
|
||||
if not url:
|
||||
return drf.response.Response(
|
||||
{"detail": "Missing 'url' query parameter"},
|
||||
|
||||
@@ -55,6 +55,31 @@ def test_api_docs_cors_proxy_valid_url(mock_getaddrinfo):
|
||||
assert response.streaming_content
|
||||
|
||||
|
||||
@unittest.mock.patch("core.api.viewsets.socket.getaddrinfo")
|
||||
@responses.activate
|
||||
def test_api_docs_cors_proxy_url_with_surrounding_whitespace(mock_getaddrinfo):
|
||||
"""
|
||||
URLs with leading or trailing whitespace must still be proxied successfully,
|
||||
otherwise images whose `src` has stray whitespace are missing from the PDF export.
|
||||
"""
|
||||
document = factories.DocumentFactory(link_reach="public")
|
||||
|
||||
# Mock DNS resolution to return a public IP address
|
||||
mock_getaddrinfo.return_value = [
|
||||
(socket.AF_INET, socket.SOCK_STREAM, 0, "", ("8.8.8.8", 0))
|
||||
]
|
||||
|
||||
client = APIClient()
|
||||
url_to_fetch = "https://external-url.com/assets/logo-gouv.png"
|
||||
responses.get(url_to_fetch, body=b"", status=200, content_type="image/png")
|
||||
response = client.get(
|
||||
f"/api/v1.0/documents/{document.id!s}/cors-proxy/?url= {url_to_fetch} "
|
||||
)
|
||||
assert response.status_code == 200
|
||||
assert response.headers["Content-Type"] == "image/png"
|
||||
assert response.streaming_content
|
||||
|
||||
|
||||
def test_api_docs_cors_proxy_without_url_query_string():
|
||||
"""Test the CORS proxy API for documents without a URL query string."""
|
||||
document = factories.DocumentFactory(link_reach="public")
|
||||
|
||||
Reference in New Issue
Block a user