WEBDIENSTE/lasuite-drive
1
0
Fork 0
mirror of https://github.com/suitenumerique/drive.git synced 2026-09-13 13:17:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

✅(frontend) improve file preview e2e test stability

Browse Source 
Switch the non-printable file test from DOCX to an audio
file so it no longer relies on WOPI (which opens in a new
tab). Wait for the PDF page to render before interacting
with the page input to avoid flaky failures. Remove an
unused variable.
This commit is contained in:
Nathan Vasse
2026-04-20 15:01:33 +02:00
parent 3c46a909e5
commit 140fb16292
1 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/frontend/apps/e2e/__tests__/app-drive/file-preview/file-preview-actions.spec.ts
+13 -9
View File
@@ -8,6 +8,7 @@ import { uploadFile } from "../utils/upload-utils";
const PDF_FILE_PATH = path.join(__dirname, "../assets/pv_cm.pdf");
const DOCX_FILE_PATH = path.join(__dirname, "../assets/empty_doc.docx");
const AUDIO_FILE_PATH = path.join(__dirname, "../assets/test-audio.mp3");
test.describe("File Preview Actions Menu", () => {
test.beforeEach(async ({ page }) => {
@@ -31,9 +32,6 @@ test.describe("File Preview Actions Menu", () => {
page,
}) => {
const filePreview = page.getByTestId("file-preview");
const moreButton = filePreview.locator(
".file-preview__header__content__right button:has(.material-icons)",
);
// Find the "..." button (more_vert icon)
const moreVertButton = filePreview.getByText("more_vert").locator("..");
@@ -106,20 +104,20 @@ test.describe("File Preview Actions Menu - Non-printable file", () => {
await page.goto("/");
await clickToMyFiles(page);
await uploadFile(page, DOCX_FILE_PATH);
await uploadFile(page, AUDIO_FILE_PATH);
await expect(
page.getByRole("cell", { name: "empty_doc", exact: true }),
page.getByRole("cell", { name: "test-audio", exact: true }),
).toBeVisible({ timeout: 10000 });
await page.getByRole("cell", { name: "empty_doc", exact: true }).dblclick();
await page
.getByRole("cell", { name: "test-audio", exact: true })
.dblclick();
await expect(page.getByTestId("file-preview")).toBeVisible({
timeout: 10000,
});
const filePreview = page.getByTestId("file-preview");
await expect(
filePreview.getByText("more_vert"),
).not.toBeVisible();
await expect(filePreview.getByText("more_vert")).not.toBeVisible();
});
});
@@ -270,6 +268,12 @@ test.describe("File Preview Navigation", () => {
await expect(title).toHaveText("pv_cm");
// Wait for the PDF to finish rendering so the controls layout is stable
// before focusing the page input.
await expect(page.locator(".react-pdf__Page").first()).toBeVisible({
timeout: 10000,
});
const pageInput = page.locator('input[aria-label="Current page"]');
await expect(pageInput).toBeVisible({ timeout: 10000 });
await pageInput.focus();