WEBDIENSTE/openswarm
1
0
Fork 0
mirror of https://github.com/openswarm-ai/openswarm.git synced 2026-09-12 04:37:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

[aidan] fix/workflow-cards: keep watched run tethered on finish to avoid duplicate chat

Browse Source
This commit is contained in:
abccodes
2026-06-18 23:30:43 -07:00
parent 8750c6a3be
commit 562d7537e9
2 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/app/pages/Workflows/WorkflowCard.tsx
+2 -2
View File
@@ -804,10 +804,10 @@ const WorkflowCard: React.FC<Props> = ({
<RunningView workflow={workflow} steps={steps} runs={runs} mode={card.sidecarKind === 'watching' ? 'sidecar-linked' : 'card'} />
)}
{card.view === 'completed' && workflow && (
<CompletedView workflow={workflow} steps={steps} runs={runs} mode={card.sidecarKind === 'viewing-completed' ? 'sidecar-linked' : 'card'} />
<CompletedView workflow={workflow} steps={steps} runs={runs} mode={(card.sidecarKind === 'viewing-completed' || card.sidecarKind === 'watching') ? 'sidecar-linked' : 'card'} />
)}
{card.view === 'failed' && workflow && (
<FailedView workflow={workflow} steps={steps} runs={runs} mode={card.sidecarKind === 'viewing-error' ? 'sidecar-linked' : 'card'} />
<FailedView workflow={workflow} steps={steps} runs={runs} mode={(card.sidecarKind === 'viewing-error' || card.sidecarKind === 'watching') ? 'sidecar-linked' : 'card'} />
)}
{card.view === 'scheduling' && workflow && (
<SchedulingView workflow={workflow} steps={steps} />
frontend/src/app/pages/Workflows/WorkflowCardLiveViews.tsx
+9 -2
View File
@@ -265,7 +265,11 @@ export function CompletedView({ workflow, steps, runs, mode = 'card' }: {
const runId = card?.runId || null;
const run = useMemo(() => (runs || []).find((r) => r.id === runId) || null, [runs, runId]);
const statuses: StepStatus[] = steps.map(() => 'done');
const isLinked = mode === 'sidecar-linked' && card?.sidecarKind === 'viewing-completed';
// A run that was being watched live stays tethered to the same chat when it
// finishes, so the still-'watching' kind counts as linked too (the slice's
// watching->viewing-completed flip can miss on fast runs). Without this the
// card offers "View Agent", which spawns a duplicate chat.
const isLinked = mode === 'sidecar-linked' && (card?.sidecarKind === 'viewing-completed' || card?.sidecarKind === 'watching');
const onDone = useCallback(() => {
dispatch(updateWorkflowCard({ workflowId: workflow.id, patch: { view: 'saved', runId: null, sidecarSessionId: null, sidecarKind: null } }));
@@ -368,7 +372,10 @@ export function FailedView({ workflow, steps, runs, mode = 'card' }: {
const statuses: StepStatus[] = steps.map((_, i) =>
i < failedIdx ? 'done' : i === failedIdx ? 'failed' : 'pending',
);
const isLinked = mode === 'sidecar-linked' && card?.sidecarKind === 'viewing-error';
// Same as CompletedView: a watched run that fails stays tethered, so treat the
// still-'watching' kind as linked and show Stop Viewing instead of View Error
// (which would open a second chat).
const isLinked = mode === 'sidecar-linked' && (card?.sidecarKind === 'viewing-error' || card?.sidecarKind === 'watching');
const onIgnore = useCallback(() => {
dispatch(updateWorkflowCard({ workflowId: workflow.id, patch: { view: 'saved', runId: null, sidecarSessionId: null, sidecarKind: null } }));