Commit Graph
17 Commits
Author SHA1 Message Date
ciregenzandClaude Opus 5 3c50359146 [eric] browser-v3: fix the instrument first, then the two composer bugs it could finally see
Six of the eleven defects here were in the MEASUREMENT, not the product, and they
were wrong in both directions.

Harness, all of which silently produced wrong numbers:
- coverage.py preflight refused every sweep on a box holding exactly one backend:
  stack.sh's supervisor is a `bash -c` quoting the whole uvicorn line, so it carries
  both "-m uvicorn backend.main" AND the venv python path. Discriminate on POSITION.
- stack.sh status reported 2 backends over 1 and 0 webpack over a live dev server
  (webpack retitles its process). A status check whose job is preventing a second
  stack, failing in the direction that lets one land.
- c7_run.sh/c8_run.sh slice r6_be.log while stack.sh names logs by TAG: a stack under
  any other tag hands every trial an empty slice and the sweep reports a confident
  0/108. Now refuses loudly; it caught this exact mistake on first use.
- "Browser command timed out" was bucketed infra. It is ONE command blowing its own
  budget, not a dead webview: all 4 such rows were BrowserFindComposer at exactly its
  30s cap, every run completed after, zero card-gone markers in the whole log. Filed
  as infra it read as 11.8% flake AND lifted holdout reach 70% -> 84%.
- api_retry / rate_limit_error now grade as infra. A provider 429 storm turned clean
  15-21s exclusions into 188s product_no_composer rows.
- bench.py prints reach BOTH ways when a row is UNVERIFIED. An exclusion resting on
  the agent's own word quietly flatters the score, and coverage.py's own instruction
  to confirm it by hand goes unread (I quoted a 100% that excluded onlinegdb).

Timing was measuring 0.2% of the run: prestage completes BEFORE metrics_started_at,
so other_ms was 25ms of a 12700ms median while prestage (4146ms, ~61%) sat in no
bucket at all. prestage_ms/task_ms are now recorded; total_ms is deliberately NOT
redefined, which would invalidate every before/after already taken against it.

Product:
- find_composer rejected ACE/CodeMirror-5/Monaco composers. Their input is a ~1x1
  offscreen textarea that paints into a sibling div, so it can never pass a size
  gate. Accept it when a VISIBLE ancestor is composer-sized; honeypots stay out
  because the input itself must not be display:none/visibility:hidden/opacity:0.
  anon reach 80% -> 100%, holdout 89% -> 90%, p95 38.6s -> 9.7s.
- the composer poll slept a blind 0+1.2+1.4 = 2.6s whenever prestage staged nothing,
  which is nearly every run, and it was the whole of other_ms's suspicious constancy
  (2610-2613ms regardless of tools_ms). Stop when two reads are identical, the rule
  the opener poll 40 lines below already applies. other_ms -53.7%, tools_ms flat.
- prestage no longer navigates to the page it is already on, nor sleeps 0.35s before
  its first settle probe.
- is_replay_boundary reasoned from the NAME alone, so x.com's composer textbox named
  "Post text" was ruled an irreversible send and truncated its replay to a bare
  navigate. Excluded by ROLE; first_unsafe_step now passes role through at all.

Measured on this box: reach 100% (83% if onlinegdb's unverified exclusion is bogus),
0 false successes in ~155 runs, prestage tier-0/1 2702ms, other_ms -53.7%, infra
flake 0/158, holdout 18/20. Criteria 2/4/9 need live writes and are untouched.
Full evidence, including what did NOT work, in e2e/browser-v3/RESULTS_2026-08-06.md.

Also drops the tracked electron/node_modules symlink pointing at another machine's
Downloads folder; it is dangling on every other checkout and re-breaks the install on
any stash or checkout.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-06 23:21:05 -07:00
ciregenz af68dcd06d [eric] send: when the task names a field, write into that field (reddit's title) 2026-08-05 08:28:38 -07:00
ciregenz 438a96eb42 [eric] skills: name the send-script's clicks so a completed write can be recorded at all 2026-08-05 07:47:01 -07:00
ciregenz 83649f5b17 Revert "[eric] browser: prove a send by the payload appearing twice, when the composer never clears"
This reverts commit 7fcce1e2f3.
2026-08-05 00:48:16 -07:00
ciregenz 7fcce1e2f3 [eric] browser: prove a send by the payload appearing twice, when the composer never clears 2026-08-05 00:45:38 -07:00
ciregenz 8298d3f604 [eric] browser: let the model name the message, so the fast lane stops needing quotes 2026-08-04 22:03:50 -07:00
ciregenz e445ca3eeb [eric] browser: fill the one field a disabled submit is waiting on, then re-ask the page 2026-08-04 20:14:50 -07:00
ciregenz 310fa1619a Revert "[eric] browser: prove a send by the posted content, not only by an emptied box"
This reverts commit 5035520629.
2026-08-04 17:49:23 -07:00
ciregenz 5035520629 [eric] browser: prove a send by the posted content, not only by an emptied box 2026-08-04 17:40:39 -07:00
ciregenz 3787123468 [eric] browser: wait longer for a slow composer to clear, so a real send stops reading as unverified 2026-08-04 17:23:57 -07:00
ciregenz ccccf9fc4c [eric] browser: probe before sleeping, so a ready page stops paying the slow page's wait 2026-08-04 16:50:44 -07:00
ciregenz bd24d0bf6c [eric] browser: a comment task must not click Create-new-post 2026-08-04 16:11:51 -07:00
ciregenz b62a29357e [eric] browser: a comment meant for a post must not land on a story 2026-08-04 15:57:30 -07:00
ciregenz 5799b3b62a [eric] browser: log the page a send filled on; correct the inflated composer-reach claim 2026-08-01 00:32:51 -07:00
ciregenz 39dbbd0a39 [eric] browser: a post or comment task can never land in a DM box, at composer or opener 2026-07-31 22:50:17 -07:00
ciregenz c9c25542b9 [eric] browser: never click a disabled submit, and turn the structural composer finder on 2026-07-31 13:03:59 -07:00
ciregenz 3d5c287139 [eric] merge: bring eric/browser onto eric/dev (30 conflicts resolved, gates green) 2026-07-30 13:18:11 -07:00