view dns show modal to test

api/app/api/v1/api_keys.py

@@ -13,9 +13,8 @@ from tools.viewdns.client import ViewDNSClient
 
 async def _test_viewdns(key_value: str) -> dict:
     client = ViewDNSClient(key_value)
-    raw = await client.ip_history("rengine.wiki")
-    record_count = len(raw.get("records", []))
-    return {"message": f"OK — {record_count} IP history records for rengine.wiki"}
+    _ = await client.ip_history("rengine.wiki")
+    return {"message": "API Key is valid."}
 
 
 API_KEY_TESTERS = {

frontend/src/lib/api/api-keys.ts

@@ -31,7 +31,7 @@ export const apiKeysApi = {
 		return api.get(`/api-keys/${keyId}/reveal`);
 	},
 
-	async test(keyId: string): Promise<{ provider: string; status: string; message: string }> {
+	async test(keyId: string): Promise<{ provider: string; success: boolean; message: string }> {
 		return api.post(`/api-keys/${keyId}/test`);
 	}
 };

frontend/src/lib/components/settings/api-keys-tab.svelte

@@ -73,6 +73,10 @@
 
 	let editPopoverOpen = $state(false);
 
+	let testDialogOpen = $state(false);
+	let testDialogKeyId = $state<string | null>(null);
+	let testDialogProvider = $state<APIProvider | null>(null);
+
 	async function fetchData() {
 		isLoading = true;
 		try {
@@ -190,10 +194,10 @@
 		testingKeyId = keyId;
 		try {
 			const result = await apiKeysApi.test(keyId);
-			if (result.status === 'not_implemented') {
-				toast.info(result.message);
+			if (result.success) {
+				toast.success(result.message);
 			} else {
-				toast.success('API key is valid');
+				toast.error(result.message);
 			}
 		} catch (e) {
 			toast.error(e instanceof Error ? e.message : 'Test failed');
@@ -490,7 +494,11 @@
 												size="sm"
 												class="h-7 px-2 text-xs"
 												disabled={testingKeyId === key.id}
-												onclick={() => handleTest(key.id)}
+												onclick={() => {
+													testDialogKeyId = key.id;
+													testDialogProvider = provider.provider;
+													testDialogOpen = true;
+												}}
 											>
 												{#if testingKeyId === key.id}
 													<Spinner class="size-3 mr-1" />
@@ -631,3 +639,42 @@
 		</Dialog.Footer>
 	</Dialog.Content>
 </Dialog.Root>
+
+<!-- test confirmation dialog -->
+
+<Dialog.Root bind:open={testDialogOpen}>
+	<Dialog.Content class="sm:max-w-md">
+		<Dialog.Header>
+			<Dialog.Title>Test API Key</Dialog.Title>
+			<Dialog.Description>
+				This will make a live API call to verify the key works. It will consume 1 API call from your
+				ViewDNS quota.
+			</Dialog.Description>
+		</Dialog.Header>
+		<Dialog.Footer>
+			<Button
+				variant="outline"
+				onclick={() => (testDialogOpen = false)}
+				disabled={testingKeyId !== null}
+			>
+				Cancel
+			</Button>
+			<Button
+				onclick={async () => {
+					if (testDialogKeyId) {
+						testDialogOpen = false;
+						await handleTest(testDialogKeyId);
+					}
+				}}
+				disabled={testingKeyId !== null}
+			>
+				{#if testingKeyId !== null}
+					<Spinner class="mr-2" />
+					Testing...
+				{:else}
+					Test
+				{/if}
+			</Button>
+		</Dialog.Footer>
+	</Dialog.Content>
+</Dialog.Root>