Files
rengine/shared/models/software.py
T
Yogesh OjhaandClaude Opus 5 0b853e04b6 chore: production-readiness review across the tree
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.

Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
  matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
  posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
  checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
  string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
  or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
  savepoint guard was blind to the case it was written for

Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing

Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
  on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component

Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice

Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.

Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
2026-09-13 18:03:29 +05:30

210 lines
6.7 KiB
Python

import uuid
from datetime import date, datetime
from pydantic import BaseModel, ConfigDict
from sqlalchemy import BigInteger, Column, Text
from sqlalchemy.types import JSON
from sqlmodel import Field, SQLModel, UniqueConstraint
from shared.definitions.evidence import Evidence
from shared.definitions.software import (
MAX_PRODUCT,
MAX_VENDOR,
Confidence,
VersionSource,
)
from shared.definitions.vulnerabilities import Severity
from shared.models.asset_query import QueryError
from shared.utils.datetime import utc_now
from shared.utils.software import MAX_CPE, MAX_NAME, MAX_VERSION
def _json_list() -> Field:
return Field(default_factory=list, sa_column=Column(JSON, nullable=False))
class NvdCve(SQLModel, table=True):
"""One published CVE, as NVD states it."""
__tablename__ = "nvd_cves"
cve: str = Field(max_length=30, primary_key=True)
severity: str | None = Field(default=None, max_length=16, index=True)
cvss_score: float | None = Field(default=None)
cvss_vector: str | None = Field(default=None, max_length=200)
description: str | None = Field(default=None, sa_column=Column(Text))
published_at: datetime | None = Field(default=None, index=True)
last_modified_at: datetime | None = Field(default=None)
class NvdCpeMatch(SQLModel, table=True):
"""One version range NVD states a CVE applies to."""
__tablename__ = "nvd_cpe_matches"
id: int | None = Field(
default=None, sa_column=Column(BigInteger, primary_key=True, autoincrement=True)
)
cve: str = Field(max_length=30, index=True)
vendor: str = Field(max_length=MAX_VENDOR)
product: str = Field(max_length=MAX_PRODUCT, index=True)
version_kind: str = Field(max_length=1)
exact_key: str | None = Field(default=None, max_length=160)
start_key: str | None = Field(default=None, max_length=160)
start_incl: bool = Field(default=False)
end_key: str | None = Field(default=None, max_length=160)
end_incl: bool = Field(default=False)
conditional: bool = Field(default=False)
class SoftwareCve(SQLModel, table=True):
"""A CVE inferred from the version an asset reports. Nothing was sent to confirm it."""
__tablename__ = "software_cves"
__table_args__ = (
UniqueConstraint("scan_id", "fingerprint", name="uq_software_scan_fingerprint"),
)
id: uuid.UUID = Field(default_factory=uuid.uuid4, primary_key=True)
scan_id: uuid.UUID = Field(foreign_key="scans.id", index=True, ondelete="CASCADE")
target_id: uuid.UUID = Field(
foreign_key="targets.id", index=True, ondelete="CASCADE"
)
project_id: uuid.UUID = Field(foreign_key="projects.id", index=True)
fingerprint: str = Field(max_length=64, index=True)
cve: str = Field(max_length=30, index=True)
# what it runs
name: str = Field(max_length=MAX_NAME, index=True)
version: str = Field(max_length=MAX_VERSION)
vendor: str = Field(max_length=MAX_VENDOR)
product: str = Field(max_length=MAX_PRODUCT, index=True)
cpe: str = Field(max_length=MAX_CPE)
version_source: str = Field(default=VersionSource.BANNER.value, max_length=16)
# what it is worth
severity: str = Field(default=Severity.UNKNOWN.value, max_length=16, index=True)
cvss_score: float | None = Field(default=None)
epss_score: float | None = Field(default=None)
epss_percentile: float | None = Field(default=None)
is_kev: bool = Field(default=False, index=True)
kev_ransomware: bool = Field(default=False)
kev_due_date: date | None = Field(default=None)
exploit_score: int = Field(default=0, index=True)
intel_kinds: list = _json_list()
confidence: str = Field(default=Confidence.HIGH.value, max_length=16, index=True)
caveats: list = _json_list()
evidence: str = Field(default=Evidence.INFERRED.value, max_length=16, index=True)
# where it is
host: str | None = Field(default=None, max_length=500, index=True)
ip: str | None = Field(default=None, max_length=45, index=True)
port: int | None = Field(default=None, index=True)
url: str | None = Field(default=None, max_length=2000)
http_asset_id: uuid.UUID | None = Field(default=None, index=True)
port_id: uuid.UUID | None = Field(default=None, index=True)
discovered_at: datetime = Field(default_factory=utc_now, index=True)
created_at: datetime = Field(default_factory=utc_now)
# ---------- read models ----------
class SoftwareCveRead(BaseModel):
id: uuid.UUID
scan_id: uuid.UUID
target_id: uuid.UUID
target_value: str | None = None
cve: str
name: str
version: str
vendor: str
product: str
cpe: str
version_source: str
version_source_label: str
severity: str
cvss_score: float | None = None
epss_score: float | None = None
epss_percentile: float | None = None
band: str | None = None
is_kev: bool = False
kev_ransomware: bool = False
kev_due_date: date | None = None
exploit_score: int = 0
intel_kinds: list[str] = []
confidence: str
confidence_label: str
caveats: list[dict] = []
evidence: str = Evidence.INFERRED.value
evidence_label: str = ""
description: str | None = None
host: str | None = None
ip: str | None = None
port: int | None = None
url: str | None = None
http_asset_id: uuid.UUID | None = None
port_id: uuid.UUID | None = None
discovered_at: datetime
is_new: bool = False
class SoftwareComponentRead(BaseModel):
"""One piece of software an asset reports, and whether it could be looked up."""
name: str
version: str | None = None
vendor: str | None = None
product: str | None = None
version_source: str
mapped: bool = False
cves: int = 0
assets: int = 0
class SoftwareCoverage(BaseModel):
"""What the inference reached, and what it could not."""
components: int = 0
mapped: int = 0
unmapped: int = 0
matched: int = 0
findings: int = 0
feed_ready: bool = False
feed_age_hours: float | None = None
stale: bool = False
unmapped_names: list[SoftwareComponentRead] = []
class SoftwareFacet(BaseModel):
key: str
label: str
count: int = 0
class SoftwareFacets(BaseModel):
severity: list[SoftwareFacet] = []
confidence: list[SoftwareFacet] = []
source: list[SoftwareFacet] = []
caveat: list[SoftwareFacet] = []
evidence: list[SoftwareFacet] = []
product: list[SoftwareFacet] = []
class SoftwarePage(BaseModel):
items: list[SoftwareCveRead] = []
total: int = 0
total_capped: bool = False
error: QueryError | None = None
class SoftwareFilter(BaseModel):
model_config = ConfigDict(extra="forbid")
q: str | None = None
limit: int = 50
offset: int = 0
sort: str | None = None
direction: str | None = None