Files
rengine/shared/services/surface_query/vulnerabilities.py
T
Yogesh OjhaandClaude Opus 5 0b853e04b6 chore: production-readiness review across the tree
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.

Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
  matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
  posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
  checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
  string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
  or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
  savepoint guard was blind to the case it was written for

Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing

Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
  on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component

Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice

Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.

Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
2026-09-13 18:03:29 +05:30

124 lines
4.1 KiB
Python

"""Vulnerability statement building, shared by the api's search and the worker's export."""
from __future__ import annotations
from typing import TYPE_CHECKING
from sqlalchemy import case, cast, func, not_, or_, select
from sqlalchemy.dialects.postgresql import JSONB
from shared.definitions.asset_query import VULN_QUERY
from shared.definitions.vulnerabilities import ACTIONABLE_SEVERITIES, SEVERITY_ORDER
from shared.models.vulnerability import Vulnerability
from shared.services.asset_query import (
QueryScope,
VulnQueryContext,
compile_vuln_query,
parse_query,
vuln_corroborated,
vuln_corroborated_ids,
vuln_is_new,
vuln_state,
vuln_suppressed,
)
if TYPE_CHECKING:
from datetime import datetime
from shared.models.vulnerability import VulnerabilityFilter
def severity_rank():
return case(
{name: index for index, name in enumerate(SEVERITY_ORDER)},
value=Vulnerability.severity,
else_=len(SEVERITY_ORDER),
)
def context(scope: QueryScope, now: datetime) -> VulnQueryContext:
return VulnQueryContext(scope=scope, now=now)
def apply_filter(query, f: VulnerabilityFilter, scope: QueryScope):
if f.severities:
query = query.where(Vulnerability.severity.in_(f.severities))
elif not f.include_info:
query = query.where(Vulnerability.severity.in_(ACTIONABLE_SEVERITIES))
if f.protocols:
query = query.where(Vulnerability.protocol.in_(f.protocols))
if f.templates:
query = query.where(Vulnerability.template_id.in_(f.templates))
if f.hosts:
query = query.where(Vulnerability.host.in_(f.hosts))
if f.scanners:
query = query.where(Vulnerability.scanner.in_(f.scanners))
if f.tags:
query = query.where(
or_(
*[
func.jsonb_exists(cast(Vulnerability.tags, JSONB), tag)
for tag in f.tags
]
)
)
if f.kev:
query = query.where(Vulnerability.is_kev.is_(True))
if f.cve:
query = query.where(
func.jsonb_array_length(cast(Vulnerability.cve_ids, JSONB)) > 0
)
if f.new:
query = query.where(vuln_is_new(scope))
if f.corroborated:
query = query.where(vuln_corroborated(scope))
if f.states:
query = query.where(vuln_state(scope).in_(f.states))
elif not f.include_suppressed:
query = query.where(not_(vuln_suppressed(scope)))
return query
def order(query, f: VulnerabilityFilter, scope: QueryScope):
if f.sort == "risk":
confirmed = vuln_corroborated_ids(scope).subquery()
return query.outerjoin(confirmed, confirmed.c.id == Vulnerability.id).order_by(
severity_rank().asc(),
Vulnerability.is_kev.desc(),
Vulnerability.exploit_score.desc(),
confirmed.c.id.isnot(None).desc(),
Vulnerability.epss_score.desc().nulls_last(),
Vulnerability.cvss_score.desc().nulls_last(),
Vulnerability.template_id.asc(),
Vulnerability.matched_at.asc(),
Vulnerability.id.asc(),
)
column = {
"severity": severity_rank(),
"name": Vulnerability.template_name,
"template": Vulnerability.template_id,
"host": Vulnerability.host,
"seen": Vulnerability.discovered_at,
"cvss": Vulnerability.cvss_score,
"epss": Vulnerability.epss_score,
"exploit": Vulnerability.exploit_score,
"type": Vulnerability.protocol,
}.get(f.sort, severity_rank())
primary = column.desc() if f.order == "desc" else column.asc()
return query.order_by(
primary.nulls_last(),
Vulnerability.template_id.asc(),
Vulnerability.matched_at.asc(),
Vulnerability.id.asc(),
)
def scoped(scope: QueryScope, f: VulnerabilityFilter, columns=None):
base = select(Vulnerability) if columns is None else select(*columns)
base = base.where(scope.match(Vulnerability.scan_id))
return apply_filter(base, f, scope)
def compiled(scope: QueryScope, f: VulnerabilityFilter, now: datetime):
return compile_vuln_query(parse_query(f.q, VULN_QUERY), context(scope, now))