Files
rengine/shared/utils/software.py
T
Yogesh OjhaandClaude Opus 5 0b853e04b6 chore: production-readiness review across the tree
A full static review of the 3.0 tree, run as two fan-out passes with every
finding verified against the running stack rather than taken on inspection.

Correctness and security
- instance settings encrypted the mask over the stored AI key: `!= MASK` never
  matched `••••••••abcd`, so saving settings destroyed the key and `test_ai`
  posted the mask as a bearer token
- the MFA token was replayable for its full five-minute life; the gate now
  checks revocation and consumes the token after a successful exchange
- logout revoked nothing for a bearer client while answering "Logged out"
- `POST /api-keys/{id}/test` returned the plaintext key inside httpx's error
  string, which embeds the whole URL
- an interest rule could be edited or deleted through another project's id
- redis ran the celery broker under `allkeys-lru`, free to evict a queued task
  or a chord counter; now `noeviction`
- nuclei's stored command carried the OAST token and every auth header
- a finalize step could poison the session and leave a scan RUNNING for ever
- `is:issue` raised TypeError on every search
- offset paging repeated and skipped rows in four dimensions
- a cancelled run kept a stale `scans.*_found` rollup
- every PDF report raised `KeyError: 'software'`
- `version_key` truncated a wide numeric run and inverted release ordering
- psycopg raises a NUL as a bare ValueError, above StatementError, so every
  savepoint guard was blind to the case it was written for

Performance
- endpoints.host had no trigram index: 35.9ms seq scan -> 0.389ms
- free text compiled to one OR, not the prescribed UNION ALL: 132ms -> 41ms
- `/http-assets/summary` and `/ips/summary` materialised whole tables
- the cross-link `ip` kind ran an estate query per page and drew nothing

Frontend
- `$effect` loaders that read the state they write, an unbounded request loop
  on a failing endpoint
- error states that rendered as empty states
- 2FA backup codes were unusable while the copy said they worked
- a "Scan history" dialog that always reported none
- ~400 duplicated lines across five filter bars, now one component

Build and tooling
- every scanner installed at @latest; all 13 pinned to the measured versions
- CI built `web/`, gone since 2.x, with tags that cannot be valid
- the prettier pre-commit hook discarded its filenames and always passed
- the test suite destroyed itself when run twice

Also: subdomains from public code, via a pinned github-subdomains source and a
GitHub API key that subfinder receives too; sublist3r and oneforall removed
after measuring one unique host in 89 across four targets.

Verified: 853 tests, ruff clean over eleven packages, svelte-check 0 errors,
the count-is-a-promise gate at 131 checks and 0 mismatches, and 143 GET routes
with no 5xx. Four migrations, each with an exercised downgrade.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DVkdx5ynZ6aof5kLFczmhX
2026-09-13 18:03:29 +05:30

165 lines
5.0 KiB
Python

"""Software identity: the version a banner states, and a key postgres can range-compare."""
from __future__ import annotations
import re
from shared.definitions.software import MAX_COMPONENTS_PER_ASSET, VersionSource
MAX_NAME = 120
MAX_VERSION = 64
MAX_CPE = 300
_SEGMENTS = 16
_PAD = 8
_ZERO = "0" * _PAD
_ALPHA_PREFIX = "~"
KIND_NUMERIC = "n"
KIND_ALPHA = "a"
_SPLIT = re.compile(r"[._\-+:~ ]+")
_VERSION_HEAD = re.compile(r"^[vV]?(\d[\w.+\-]*)$")
_BANNER = re.compile(r"^([^/\s]+)(?:/(\S+))?")
_PAREN = re.compile(r"\(([^)]*)\)")
_UNESCAPE = re.compile(r"\\(.)")
_RUNS = re.compile(r"\d+|[^\d]+")
_TRAILING_JUNK = re.compile(r"[^\w.+\-]+$")
DISTRO_MARKERS: frozenset[str] = frozenset(
{
"ubuntu",
"debian",
"centos",
"red hat",
"redhat",
"rhel",
"fedora",
"suse",
"alpine",
"amazon",
"oracle",
"rocky",
"almalinux",
}
)
def _numeric_segment(run: str) -> str:
"""A run wider than the pad clamps rather than truncating, which would invert the order."""
trimmed = run.lstrip("0") or "0"
return trimmed.zfill(_PAD) if len(trimmed) <= _PAD else "9" * _PAD
def version_key(version: str | None) -> str | None:
"""Zero-padded so a string comparison in SQL orders versions correctly."""
if not version:
return None
parts: list[str] = []
for token in _SPLIT.split(version.strip()):
for run in _RUNS.findall(token):
if run.isdigit():
parts.append(_numeric_segment(run))
else:
parts.append(f"{_ALPHA_PREFIX}{run.lower()[:_PAD]}")
if len(parts) >= _SEGMENTS:
return ".".join(parts)
while len(parts) > 1 and parts[-1] == _ZERO:
parts.pop()
return ".".join(parts) or None
def version_kind(key: str | None) -> str | None:
"""Numeric and alphabetic version schemes are never ordered against each other."""
if not key:
return None
return KIND_ALPHA if key.startswith(_ALPHA_PREFIX) else KIND_NUMERIC
def clean_version(raw: str | None) -> str | None:
"""A version a tool stated, or None when what it stated is not one."""
if not raw:
return None
value = _TRAILING_JUNK.sub("", raw.strip())[:MAX_VERSION]
match = _VERSION_HEAD.match(value)
return match.group(1) if match else None
def parse_tech(entry: str) -> tuple[str, str | None]:
"""httpx writes a technology as Name or Name:version."""
name, _, tail = entry.strip().rpartition(":")
if not name:
return entry.strip()[:MAX_NAME], None
version = clean_version(tail)
if version is None:
return entry.strip()[:MAX_NAME], None
return name.strip()[:MAX_NAME], version
def parse_banner(banner: str | None) -> tuple[str | None, str | None, str | None]:
"""A Server header states product, version and often the distribution that built it."""
if not banner:
return None, None, None
head = _BANNER.match(banner.strip())
if head is None:
return None, None, None
product = head.group(1)[:MAX_NAME] or None
version = clean_version(head.group(2))
distro = None
for note in _PAREN.findall(banner):
marker = note.strip().lower()
if marker in DISTRO_MARKERS:
distro = marker
break
return product, version, distro
def normalize_product(name: str) -> str:
"""The shape NVD writes a product in: lower case, words joined, dots kept."""
lowered = _UNESCAPE.sub(r"\1", name.strip().lower())
collapsed = re.sub(r"[^a-z0-9.]+", "_", lowered)
return collapsed.strip("_")
def cpe23(vendor: str, product: str, version: str | None) -> str:
"""A CPE 2.3 string with the version filled in, escaped as the dictionary escapes it."""
field = _cpe_escape(version) if version else "*"
return (
f"cpe:2.3:a:{_cpe_escape(vendor)}:{_cpe_escape(product)}:{field}:*:*:*:*:*:*:*"[
:MAX_CPE
]
)
def _cpe_escape(value: str) -> str:
return re.sub(r"([:\\*?!\"#$%&'()+,/;<=>@\[\]^`{|}~])", r"\\\1", value)
def components_of(tech: list[str], webserver: str | None) -> list[dict]:
"""A technology that names its version is the only one a CVE lookup can use."""
seen: set[tuple[str, str]] = set()
out: list[dict] = []
for entry in tech:
name, version = parse_tech(str(entry))
if not version or (name, version) in seen:
continue
seen.add((name, version))
out.append(
{
"name": name,
"version": version,
"source": VersionSource.FINGERPRINT.value,
}
)
if len(out) >= MAX_COMPONENTS_PER_ASSET:
return out
product, version, distro = parse_banner(webserver)
if product and version and (product, version) not in seen:
out.append(
{
"name": product,
"version": version,
"source": VersionSource.BANNER.value,
"distro": distro,
}
)
return out