WEBDIENSTE/unbound
1
0
Fork 0
mirror of https://github.com/NLnetLabs/unbound.git synced 2026-08-17 21:25:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve Windows NSIS installer script (setup.nsi) (#831)

Browse Source 
* Improve Windows NSIS installer script (setup.nsi)

Two improvements of installer script :
- avoid error message when Unbound is running,
- add "DisplayVersion" in registry thus Windows package manager (Winget) can handle Unbound.

* Update setup.nsi ask user to stop unbound service + DisplayVersion in Windows registry
This commit is contained in:
Pierre4012
2024-03-25 16:43:49 +01:00
committed by GitHub
parent 73bd5a19aa
commit ef60dcac31
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
winrc/setup.nsi
+10
View File
@@ -78,6 +78,15 @@ section "Root anchor - DNSSEC" SectionRootKey
sectionEnd
section "-hidden.postinstall"
# if Unbund is already installed, ask to stop it to allow file replacement
IfFileExists "$INSTDIR\unbound-service-remove.exe" 0 next_label
MessageBox MB_YESNO "Unbound is already installed! Would you like to stop the service to continue with the update?" /SD IDYES IDNO false_label # defaults to yes on silent installations
nsExec::ExecToLog '"$INSTDIR\unbound-service-remove.exe" stop'
Sleep 1000
Goto next_label
false_label:
Quit
next_label:
# copy files
SetRegView 64
setOutPath $INSTDIR
@@ -134,6 +143,7 @@ section "-hidden.postinstall"
# register uninstaller
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\Unbound" "DisplayName" "Unbound"
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\Unbound" "DisplayVersion" "${VERSION}"
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\Unbound" "UninstallString" "$\"$INSTDIR\uninst.exe$\""
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\Unbound" "QuietUninstallString" "$\"$INSTDIR\uninst.exe$\" /S"
WriteRegDWORD HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\Unbound" "NoModify" "1"