WEBDIENSTE/volatility3
1
0
Fork 0
mirror of https://github.com/volatilityfoundation/volatility3.git synced 2026-08-26 08:02:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove the python implementation of __getattribute__ for speed.

Browse Source 
The __getattribute__ method is called for *all* attribute lookups, and
the python implementation is likely slow.  The only function the python
implementation provided was to check that properties started with
helper_.  Since this only provided a log message, we could add it back
in only if the log level is high enough?  Either way, it's not
significant enough to warrant costing extra time in every attribute
lookup on every object.
This commit is contained in:
Mike Auty
2018-07-30 23:58:02 +01:00
parent 552101b593
commit bca972f28a
1 changed files with 2 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
volatility/framework/objects/__init__.py
+2 -19
View File
@@ -599,27 +599,10 @@ class Struct(interfaces.objects.ObjectInterface):
"""Specifically named method for retrieving members."""
return self.__getattr__(attr)
def __getattribute__(self, attr: str) -> typing.Any:
"""Make sure that class overrides all start with helper_"""
if attr in ['__dict__', '__class__'] or attr in self.__dict__:
return object.__getattribute__(self, attr)
if not isinstance(getattr(self.__class__, attr), property):
return object.__getattribute__(self, attr)
elif not hasattr(Struct, attr) and not attr.startswith('helper_'):
# Is a property, of an override class that doesn't start with helper
vollog.debug("Deprecated non-helper attribute {} requested from class override {}".format(attr,
self.vol.type_name))
# Uncomment the following line if we want to prohibit using non-helper properties
# return self.__getattr__(attr)
# Change this to an attribute error if we want to prohibit rather than deprecate member collisisons
return object.__getattribute__(self, attr)
def __getattr__(self, attr: str) -> typing.Any:
"""Method for accessing members of the type"""
if attr in self.__getattribute__("_concrete_members"):
return self.__getattribute__("_concrete_members")[attr]
if attr in self._concrete_members:
return self._concrete_members[attr]
elif attr in self.vol.members:
mask = self._context.memory[self.vol.layer_name].address_mask
relative_offset, member = self.vol.members[attr]